[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156147

--- Comment #109 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 280020
  --> https://bugs.webkit.org/attachment.cgi?id=280020
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280020&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:624
>> +        if (UNLIKELY(m_runtimeFlags.isAsyncAwaitEnabled() && matchContextualKeyword(m_vm->propertyNames->async))) {
> 
> There is a chance that this may be faster if the LHS and RHS were swapped because it might aid the register allocator. 
> Same with the similar compare elsewhere.
> Is this what's slowing down the parser?
> Have you tried making ASYNC a key word? That may be faster than checking the IDENT's StringImpl

When executing `matchContextualKeyword(m_vm->propertyNames->async)`, it becomes `Identifier == Identifier` check and it should be pointer comparison because Identifier is already interned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160528/ac529b4e/attachment-0001.html>