[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156147

--- Comment #88 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 279829
  --> https://bugs.webkit.org/attachment.cgi?id=279829
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279829&action=review

I've run benchmarks (report dumped to https://gist.github.com/caitp/26b24e076ace641ae7c8a9304da3d07c) --- It doesn't look that good, even with the flag.

I'll see if I can improve this a bit tomorrow.

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:656
>> +    if (SourceParseMode::ArrowFunctionMode == parseMode || SourceParseMode::AsyncArrowFunctionBodyMode == parseMode || SourceParseMode::AsyncArrowFunctionMode == parseMode) {
> 
> Please add a comment about why AsyncArrowFunctionBodyMode is listed here.
> (comment about the system that async arrow function body looks up the arrow function's context).

Done, and added some new tests which go a bit deeper into this (and fixed some bugs related to this)

>> Source/JavaScriptCore/parser/ASTBuilder.h:386
>> +            usesArrowFunction();
> 
> Is this usesArrowFunction() here correct? These functions are not arrow functions, right?
> If the body is specially handled, please add a comment about how the body is handled.

It's not needed, removed.

>> Source/JavaScriptCore/parser/Parser.cpp:3541
>> +            goto parseProperty;
> 
> Is it safe for `async hello: value` property?
> I think we need to chek !isAsyncMethod in match(COLON) phase to avoid it.
> And please add the test to ensure that JSC makes `async hello: value` case SyntaxError.

You are right... Added a fix and tests or this

>> Source/JavaScriptCore/parser/Parser.h:1579
>> +        ASSERT(false);
> 
> should be RELEASE_ASSERT_NOT_REACHED()

Alright

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160526/54fd76b2/attachment.html>