[Webkit-unassigned] [Bug 158066] New: REGRESSION(r201066): [GTK] Several intl tests started to fail in GTK+ bot after r201066

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158066

            Bug ID: 158066
           Summary: REGRESSION(r201066): [GTK] Several intl tests started
                    to fail in GTK+ bot after r201066
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: Gtk, LayoutTestFailure
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com

This is because since r201066 JSC also uses the preferred language from the system locale instead of falling back to "en" and those tests expect the locale to be en_US. run-javascriptcore-tests does $ENV{LANG}="en_US.UTF-8"; but we are not actually honoring the environment variables at all when using jsc binary. We are using setlocale with a nullptr locale to get the current one, but the current one is always "C", because to set the locale according to the environment variables we need to call setlocale with an empty string as locale. That's done by gtk_init(), which is called by all our binaries (web process, network process, etc.), but not by jsc (because jsc doesn't depend on GTK+). The reason why it has always worked for EFL is because they call ecore_init() in jsc that calls setlocale.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160525/d8d4e90c/attachment.html>