[Webkit-unassigned] [Bug 157924] REGRESSION (r188642): All pages are blank when printing a webpage in iOS Safari

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 19 17:56:03 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157924

--- Comment #7 from Andy Estes <aestes at apple.com> ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > There are two issues I think:
> > > 
> > > 1) The functional style would have you let WTF::Condition do the time math
> > > for you.  Instead of having a wait loop, do:
> > > 
> > > m_condition.waitFor(m_lock, timeout, [&] () -> bool { loop body });
> > 
> > Unfortunately this would just move the overflow into
> > Condition::absoluteFromRelative(), where have these two lines:
> > 
> >     Clock::duration myRelativeTimeout =
> >         std::chrono::duration_cast<Clock::duration>(relativeTimeout);
> > 
> >     return Clock::now() + myRelativeTimeout;
> > 
> > libc++ represents both nanoseconds and milliseconds using the same type
> > (long long), so the duration_cast will overflow trying to convert the
> > largest long long into an even larger number of nanosecond ticks. Now we're
> > right back where we started, subtracting from Clock::now() instead of adding.
> 
> Can you file a bug about that? :-)

Sure thing! https://bugs.webkit.org/show_bug.cgi?id=157937

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160520/f5ced7ac/attachment-0001.html>


More information about the webkit-unassigned mailing list