[Webkit-unassigned] [Bug 157753] New: Consider renaming activeDOMObjectsAreSuspended() to areActiveDOMObjectsSuspendingOrSuspended() for clarity
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 16 13:49:26 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=157753
Bug ID: 157753
Summary: Consider renaming activeDOMObjectsAreSuspended() to
areActiveDOMObjectsSuspendingOrSuspended() for clarity
Classification: Unclassified
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebCore JavaScript
Assignee: webkit-unassigned at lists.webkit.org
Reporter: adachan at apple.com
ScriptExecutionContext::stopActiveDOMObjects() has always set m_activeDOMObjectsAreStopped to true before stopping the objects. For ScriptExecutionContext::suspendActiveDOMObjects(), we've recently changed it to set m_activeDOMObjectsAreSuspended to true earlier to be consistent with the stop case in http://trac.webkit.org/changeset/200965.
Since the underlying booleans are updated right before we actually suspend/stop the objects, we should rename them to
m_activeDOMObjectsAreSuspendingOrSuspended
m_activeDOMObjectsAreStoppingOrStopped
for clarity.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160516/893ee459/attachment.html>
More information about the webkit-unassigned
mailing list