[Webkit-unassigned] [Bug 157665] cross-fade() rendering doesn't match expectation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 22:40:39 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157665

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
We're dropping the blend mode on the floor (but need to fix the transparency layer case).

Probably regressed in r157045.

diff --git a/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp b/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp
index 57e3f1a4f1906a2669ffffdd201559cb3eb5ca16..4acfd8ad22800cf2173f1dab8a79f54c8f9092fc 100644
--- a/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp
+++ b/Source/WebCore/platform/graphics/CrossfadeGeneratedImage.cpp
@@ -51,7 +51,7 @@ static void drawCrossfadeSubimage(GraphicsContext& context, Image& image, Compos

     GraphicsContextStateSaver stateSaver(context);

-    context.setCompositeOperation(operation);
+//    context.setCompositeOperation(operation);

     if (useTransparencyLayer)
         context.beginTransparencyLayer(opacity);
@@ -60,7 +60,7 @@ static void drawCrossfadeSubimage(GraphicsContext& context, Image& image, Compos

     if (targetSize != imageSize)
         context.scale(FloatSize(targetSize.width() / imageSize.width(), targetSize.height() / imageSize.height()));
-    context.drawImage(image, IntPoint());
+    context.drawImage(image, IntPoint(), ImagePaintingOptions(operation));

     if (useTransparencyLayer)
         context.endTransparencyLayer();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160513/ccdb1071/attachment.html>


More information about the webkit-unassigned mailing list