[Webkit-unassigned] [Bug 157167] r200216 fails to build for darwin/gtk: use of undeclared identifier 'm_font'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157167

--- Comment #18 from Myles C. Maxfield <mmaxfield at apple.com> ---
(In reply to comment #17)
> Comment on attachment 278242 [details]
> proposed change
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=278242&action=review
> 
> >> Source/WebCore/platform/graphics/FontPlatformData.h:176
> >>  #if USE(APPKIT)
> > 
> > I'm not familiar with how the Darwin/GTK port is configured. Will this work if it is changed to PLATFORM(MAC)?
> > 
> > If so, I think we should migrate to it; otherwise, I suppose it's fine how it is.
> 
> Yes, it will work with PLATFORM(MAC).
> 
> No, I don’t agree that we should migrate to it.
> 
> We should talk in person about our long term direction for platform #if
> statements; our goal was to use things like USE(APPKIT) to tell us whether
> to use an AppKit class like NSFont, rather than something more like
> PLATFORM(MAC). Maciej was the original visionary for this, although we have
> not moved very far in that direction.

Ultimately, we want to move off NSFont wholesale.

Perhaps we need a USE(CORETEXT)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160506/ea58c520/attachment.html>