[Webkit-unassigned] [Bug 157403] AX: String for document range is empty if end visible position anchors to a ignored replaced node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157403

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #278215|review?                     |review+
              Flags|                            |

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 278215
  --> https://bugs.webkit.org/attachment.cgi?id=278215
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=278215&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:2000
> +    // Sometimes when the node is a replaced node and is ignored in accessibility, we get wrong CharacterOffset from it.

we get "a" wrong

> Source/WebCore/accessibility/AXObjectCache.cpp:2002
> +    if  (result.remainingOffset > 0 && !result.isNull() && isRendererReplacedElement(result.node->renderer()))

is remainingOffset signed or unsigned.... if unsigned you can drop the > 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160506/b8082031/attachment.html>