[Webkit-unassigned] [Bug 157401] Add dyldSPI.h for linked on or after checks, and add one for link preview

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 17:38:16 PDT 2016


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #278206|review?                     |review-
              Flags|                            |

--- Comment #2 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 278206
  --> https://bugs.webkit.org/attachment.cgi?id=278206

View in context: https://bugs.webkit.org/attachment.cgi?id=278206&action=review

> Source/WTF/wtf/spi/darwin/dyldSPI.h:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.

Pretty sure this is all new 2016 stuff.

> Source/WTF/wtf/spi/darwin/dyldSPI.h:27
> +#ifndef WTF_dyldSPI_h
> +#define WTF_dyldSPI_h

We’ve switched to using #pragma once in new files

> Source/WTF/wtf/spi/darwin/dyldSPI.h:40
> +#elif PLATFORM(IOS)
> +static const uint32_t firstSDKVersionWithInitConstructorSupport = 0x80000; // iOS 8.0.0
> +static const uint32_t firstSDKVersionWithLinkPreviewEnabledByDefault = 0xA0000;
> +#elif PLATFORM(MAC)
> +static const uint32_t firstSDKVersionWithInitConstructorSupport = 0xA0A00; // OSX 10.10.0
> +#endif

This things are neither dyld SPI nor WTF-related. They should stay in their respective projects.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:235
> + @discussion The default value is NO on iOS 9, and YES on iOS linked on or after WK_IOS_TBS.

TBS? The script that post-processes API headers is not going to do anything pretty with this WK_IOS_TBS (nor with WK_IOS_TBA). More importantly, anyone seeing this comment will be looking at the iOS TBA SDK, and therefore linking against that SDK. There’s no need to confuse them with telling them about behavior that won’t apply to them.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:493
> +    static uint32_t programSDKVersion = 0;
> +    if (!programSDKVersion)
> +        programSDKVersion = dyld_get_program_sdk_version();

Since this is C++, you just say
static uint32_t programSDKVersion = dyld_get_program_sdk_version();
and it will do one-time initialization.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160506/8619a64e/attachment-0001.html>

More information about the webkit-unassigned mailing list