[Webkit-unassigned] [Bug 116046] For keyboard users, activating a fragment URL should transfer focus and caret to the destination

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 5 13:15:14 PDT 2016


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #278175|review?                     |review+
              Flags|                            |

--- Comment #40 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 278175
  --> https://bugs.webkit.org/attachment.cgi?id=278175

View in context: https://bugs.webkit.org/attachment.cgi?id=278175&action=review

> Source/WebCore/dom/Document.cpp:3941
> +    if (Element* sibling = direction == FocusDirectionForward ? ElementTraversal::previous(*node) : ElementTraversal::next(*node))
> +        return sibling;

I think we want to add a comment saying that sibling needs to be an element prior to the next focusable element.

> Source/WebCore/dom/Document.cpp:4085
> +    return node.previousSibling() ?: node.parentNode();

Use || instead.

> Source/WebCore/dom/Document.cpp:4101
> +    // We need to update m_focusNavigationStartingNode if its ancestor has been removed.

This comment is tautological. Remove it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160505/a97081ae/attachment-0001.html>

More information about the webkit-unassigned mailing list