[Webkit-unassigned] [Bug 116046] For keyboard users, activating a fragment URL should transfer focus and caret to the destination

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 22:32:15 PDT 2016


--- Comment #36 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 277305
  --> https://bugs.webkit.org/attachment.cgi?id=277305

View in context: https://bugs.webkit.org/attachment.cgi?id=277305&action=review

Will address other issues.

>> Source/WebCore/dom/Document.cpp:3934
>> +        return downcast<Element>(node);
> Step 2 checks of https://html.spec.whatwg.org/multipage/interaction.html#sequential-focus-navigation-starting-point says:

We always return the m_focusedElement when it's not null. m_focusableElement will be set to null if we are trying to focus on unfocusable element, and m_focusNavigationStartingPoint will take place.

>> Source/WebCore/dom/Document.cpp:3936
>> +        return sibling;
> Isn't this backwards?

Here we are using the sibling as a search starting point to find the next focusable element. So when going forward, next element might be the one we want to focus on when hitting tab. We use previous here to make sure we won't skip the next Element. Same goes for the going backwards case.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160505/6da1b807/attachment.html>

More information about the webkit-unassigned mailing list