[Webkit-unassigned] [Bug 157297] Web Inspector: console.assert should do far less work when the assertion is true

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 3 08:32:36 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157297

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 277972
  --> https://bugs.webkit.org/attachment.cgi?id=277972
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=277972&action=review

> Source/JavaScriptCore/runtime/ConsoleClient.h:53
> +    void assertion(ExecState*, RefPtr<Inspector::ScriptArguments>&&);

The right name for this seems to be "assertionFailed".

Longer term, really puzzled about the fact that ScriptArguments is a reference counted object.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160503/945e5c63/attachment.html>


More information about the webkit-unassigned mailing list