[Webkit-unassigned] [Bug 157270] Add fail-fast option to run-javascriptcore-tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 2 13:09:50 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=157270
Sri Vijayaraghavan <svijayaraghavan at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ap at webkit.org
--- Comment #4 from Sri Vijayaraghavan <svijayaraghavan at apple.com> ---
(In reply to comment #2)
> Comment on attachment 277912 [details]
> Patch
>
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=277912&action=review
>
> r=me
>
> > Tools/Scripts/run-javascriptcore-tests:211
> > + if ($failFast) {
> > + exit exitStatus($testapiResult) if $testapiResult;
>
> Since we have two conditions here, I think it's clearer to merge them into
> one if statement:
>
> if ($testapiResult && $failFast) {
> exit...
> }
Thanks! I've fixed this.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160502/04f75d62/attachment.html>
More information about the webkit-unassigned
mailing list