[Webkit-unassigned] [Bug 157249] New: Deduplicated initializer lists of BitmapImage constructors.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 1 14:37:08 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=157249
Bug ID: 157249
Summary: Deduplicated initializer lists of BitmapImage
constructors.
Classification: Unclassified
Product: WebKit
Version: WebKit Local Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Images
Assignee: webkit-unassigned at lists.webkit.org
Reporter: annulen at yandex.ru
BitmapImage has 3 constructors, which initialize the same variables. Because of this duplication it's easy to leave some field uninitialized in some code path. Actually, there are already which are already left initialized in 1 or 2 of constructors, e.g. m_desiredFrameStartTime, m_decodedPropertiesSize, m_progressiveLoadChunkTime, m_progressiveLoadChunkCount, m_hasUniformFrameSize.
Use constructor delegation and inline filed initializers to avoid this problem.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160501/4f0f2209/attachment.html>
More information about the webkit-unassigned
mailing list