[Webkit-unassigned] [Bug 156060] Fix WEB_PROCESS_CMD_PREFIX and NETWORK_PROCESS_CMD_PREFIX after r196500

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 31 16:02:32 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156060

--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 275274
  --> https://bugs.webkit.org/attachment.cgi?id=275274
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275274&action=review

> Source/WebKit2/UIProcess/Databases/DatabaseProcessProxy.h:87
> +#if PLATFORM(GTK) || PLATFORM(EFL)
>      void platformGetLaunchOptions(ProcessLauncher::LaunchOptions&);
> +#else
> +    void platformGetLaunchOptions(ProcessLauncher::LaunchOptions&) { }
> +#endif

A much better way to do this is to write this, outside the class body:

    #if !(PLATFORM(GTK) || PLATFORM(EFL))
    inline void DatabaseProcessProxy::platformGetLaunchOptions(ProcessLauncher::LaunchOptions&)
    {
    }
    #endif

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160331/9d726896/attachment.html>


More information about the webkit-unassigned mailing list