[Webkit-unassigned] [Bug 155545] [ES6] Class syntax. Access to new.target inside of the eval should not lead to SyntaxError

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 14:49:36 PDT 2016


--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 275212
  --> https://bugs.webkit.org/attachment.cgi?id=275212

View in context: https://bugs.webkit.org/attachment.cgi?id=275212&action=review

> Source/JavaScriptCore/runtime/CodeCache.cpp:86
> +UnlinkedCodeBlockType* CodeCache::getGlobalCodeBlock(VM& vm, ExecutableType* executable, const SourceCode& source, JSParserBuiltinMode builtinMode, JSParserStrictMode strictMode, ThisTDZMode thisTDZMode, bool, DebuggerMode debuggerMode, ProfilerMode profilerMode, ParserError& error, bool isParantProgramParseMode, const VariableEnvironment* variablesUnderTDZ)

Is this truly just the parent? Or is this parent or self is program?
i.e, should a Program node be true or false for this?

> Source/JavaScriptCore/runtime/CodeCache.cpp:147
> +    return getGlobalCodeBlock<UnlinkedModuleProgramCodeBlock>(vm, executable, source, builtinMode, JSParserStrictMode::Strict, ThisTDZMode::CheckIfNeeded, false, debuggerMode, profilerMode, error, false, &emptyParentTDZVariables);

It doesn't make sense that this is different from UnlinkedProgramCodeBlock

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160330/8486aeae/attachment.html>

More information about the webkit-unassigned mailing list