[Webkit-unassigned] [Bug 156027] New: Avoid WebCore-prefixed paths when building WebCore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 30 10:23:33 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156027

            Bug ID: 156027
           Summary: Avoid WebCore-prefixed paths when building WebCore
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

A few files (e.g., “Font.h”, "ColorCG.h", some Video files) refer to “<WebCore/CoreGraphicsSPI.h>”, which doesn’t always exist on Windows at the time the file is compiled. The CoreGraphicsSPI.h file lives in “WebCore/platform/spi/cg/CoreGraphicsSPI.h”, and can be found with a normal ‘#include “CoreGraphicsSPI.h”. It’s only after a post-build step copies the file to “DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h” that the ‘#include <WebCore/CoreGraphicsSPI.h>” form works.

When a non-clean build is performed, this is fine, so EWS probably works properly most of the time. But if something prompts it to clean the build output, the file doesn’t exist and the build fails, improperly blaming the current patch.

We should be consistent about file access in WebCore so that we avoid these problems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160330/aa323cfe/attachment.html>


More information about the webkit-unassigned mailing list