[Webkit-unassigned] [Bug 155997] New: REGRESSION (r198782): CGImageSourceUpdateData() is called twice with the same data every time ImageSource::setData() is called

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155997

            Bug ID: 155997
           Summary: REGRESSION (r198782): CGImageSourceUpdateData() is
                    called twice with the same data every time
                    ImageSource::setData() is called
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com

This bug causes logging an error message saying "CGImageSourceUpdateData image source was already finalized".

When refactoring the code of ImageSource::setData(SharedBuffer* data), I moved its code to ImageDecoder::setData(SharedBuffer* data). And as a preparation for the asynchronous image decoding work, I added another ImageDecoder::setData(CFDataRef data), and I intended to call it from ImageDecoder::setData(SharedBuffer* data) for now and then I am going to call it also from the asynchronous image decoding code path.

The bug is I left the old CGImageSourceUpdateData() in ImageDecoder::setData(SharedBuffer* data) after calling ImageDecoder::setData(CFDataRef data).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160329/69b22649/attachment-0001.html>