[Webkit-unassigned] [Bug 155745] [GTK] Inspector crashes when using the console

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155745

--- Comment #6 from Alejandro G. Castro <alex at igalia.com> ---
Comment on attachment 275093
  --> https://bugs.webkit.org/attachment.cgi?id=275093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=275093&action=review

Just tested it, it works for me, thanks. Apparently the linker was not sorting out the situation with 2 definitions of a symbol very well, maybe in case of Apple their linker was smarter or just luckier.

> Source/JavaScriptCore/ChangeLog:15
> +        always end up using the one in WebKit2. Since the

Did you mean JavaScriptCore here?

>> Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:298
>> +            lines.append('            m_result->%(keyedSet)s(ASCIILiteral("%(name)s"), Inspector::Protocol::%(enumsNamespace)s::getEnumConstantValue(value));' % setter_args)
> 
> I am surprised that removing the cast doesn't cause a compiler error.

The function with T type used that does the cast to int is defined up in the file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160329/8ec7ae2a/attachment.html>