[Webkit-unassigned] [Bug 155747] Use Region instead of IntRect in PageClient and WebPageProxy setViewNeedsDisplay method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 29 00:27:35 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155747

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> Comment on attachment 274740 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274740&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:70
> > +    RefPtr<cairo_region_t> damageRegion = toCairoRegion(region);
> > +    gtk_widget_queue_draw_region(m_viewWidget, damageRegion.get());
> 
> If you ever care to return here you could make this a 1-liner:
> 
>     gtk_widget_queue_draw_region(m_viewWidget, toCairoRegion(region).get());
> 
> That’s part of the magic of smart pointers!

Sure, done in r198775

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160329/3f72287b/attachment-0001.html>


More information about the webkit-unassigned mailing list