[Webkit-unassigned] [Bug 155858] Autoscrolling from a drag selection does not work in full screen, or when the window is against the screen edge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155858

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Beth Dakin <bdakin at apple.com> ---
Thanks Simon!

(In reply to comment #10)
> Comment on attachment 274942 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=274942&action=review
> 
> > Source/WebCore/page/mac/EventHandlerMac.mm:1125
> > +    float insetScreenLeftEdge = screenLeftEdge + EDGE_DISTANCE_THRESHOLD;
> > +    float screenRightEdge = screenRect.maxX();
> > +    float insetScreenRightEdge = screenRightEdge - EDGE_DISTANCE_THRESHOLD;
> 
> You could inset the rect to get insetScreenLeftEdge, insetScreenRightEdge
> which is slightly cleaner.
> 

Somehow I missed this comment before I committed, but also this strikes me as a slightly more confusing way to do things. (Though maybe I am not thinking of exactly the same rect insetting code that you are?)

> > Source/WebCore/platform/PlatformScreen.h:68
> > +    NSScreen *screenForDisplayID(PlatformDisplayID displayID);
> 
> No need for displayID name.

Removed.

http://trac.webkit.org/changeset/198692

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/e6d8d957/attachment.html>