[Webkit-unassigned] [Bug 155858] Autoscrolling from a drag selection does not work in full screen, or when the window is against the screen edge

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155858

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274942|review?                     |review+
              Flags|                            |

--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 274942
  --> https://bugs.webkit.org/attachment.cgi?id=274942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274942&action=review

> Source/WebCore/page/mac/EventHandlerMac.mm:1125
> +    float insetScreenLeftEdge = screenLeftEdge + EDGE_DISTANCE_THRESHOLD;
> +    float screenRightEdge = screenRect.maxX();
> +    float insetScreenRightEdge = screenRightEdge - EDGE_DISTANCE_THRESHOLD;

You could inset the rect to get insetScreenLeftEdge, insetScreenRightEdge which is slightly cleaner.

> Source/WebCore/platform/PlatformScreen.h:68
> +    NSScreen *screenForDisplayID(PlatformDisplayID displayID);

No need for displayID name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/ef513f2a/attachment.html>