[Webkit-unassigned] [Bug 155871] New: [Win] Improve CMake build performance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 24 22:18:11 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155871

            Bug ID: 155871
           Summary: [Win] Improve CMake build performance
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bfulgham at webkit.org

The time required to build our Windows WebKit builds has increased significantly since we switched to CMake.

While investigating this I noticed that we no longer use the DerivedSources.cpp "all in one" file to drive the build of our Derived Sources. We started using this years ago to address long link times and other build problems, so I don't think we should have stopped using it.

This patch corrects the build as follows:
1. It uses "DerivedSources.cpp"
2. To avoid breaking CMake dependency analysis, we revise the VS projects to show the header for each auto generated file, which forces CMake to make sure they are kept in sync, without causing VS to actually build the files.
3. Updates "DerivedSources.cpp" with some new files that were added since the last time it was updated.

Although its annoying to keep DerivedSources.cpp in sync with the other pieces of the build system, it's no worse than the dozen or so other "all in one" files we already use (on multiple ports). Plus, it's unlikely we will break this in the future because a missing file just means that VS builds it separately, slightly slowing the build. Of course, removing an IDL file without updating the DerivedSources file could break the build, but EWS should show that quite clearly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160325/49bff591/attachment.html>


More information about the webkit-unassigned mailing list