[Webkit-unassigned] [Bug 155576] Improve update-webkit-dependency script

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 24 10:54:13 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155576

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274259|review?                     |review+, commit-queue+
              Flags|                            |

--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 274259
  --> https://bugs.webkit.org/attachment.cgi?id=274259
Patch to improve update-webkit-dependency.

View in context: https://bugs.webkit.org/attachment.cgi?id=274259&action=review

This looks fine to me. We can roll it out if we encounter problems. r=me.

> Tools/Scripts/update-webkit-dependency:197
> +my $prefixDirectoryPathInZipFile = "$file/".(($prefixInZip eq ".") ? "" : "$prefixInZip/");

The use of the UNIX-style slash here *might* be a problem on Windows, but I'm not sure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160324/00942636/attachment.html>


More information about the webkit-unassigned mailing list