[Webkit-unassigned] [Bug 155796] Ninja build path is incorrect when git branch name is appended to WebKitBuild

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 23 19:01:05 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155796

--- Comment #5 from Bill Ming <mbbill at gmail.com> ---
(In reply to comment #3)
> Comment on attachment 274753 [details]
> Patch
> 
> I'm glad to hear from people building with different configurations!
> 
> Would it work to use determineBaseProductDir(); and chdir $baseProductDir ? 
> That would probably be cleaner, so we don't have to add the same git checks
> in two different places.

Thanks for the review. The patch is updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160324/96cb1914/attachment.html>


More information about the webkit-unassigned mailing list