[Webkit-unassigned] [Bug 155698] Fixed compilation with GCC 4.8.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 20 22:34:26 PDT 2016


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #274541|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 274541
  --> https://bugs.webkit.org/attachment.cgi?id=274541

View in context: https://bugs.webkit.org/attachment.cgi?id=274541&action=review

> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:59
> +    ImpureDataSlot(HeapLocation _key, LazyNode _value, unsigned _hash)
> +        : key(_key), value(_value), hash(_hash)

There is no need to add leading underscores here. The following is valid C++ that implements the same behavior:

    ImpureDataSlot(HeapLocation key, LazyNode value, unsigned hash)
        : key(key), value(value), hash(hash)

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160321/4d133e15/attachment.html>

More information about the webkit-unassigned mailing list