[Webkit-unassigned] [Bug 155693] New: Rethink the JITOperations calling convention

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155693

            Bug ID: 155693
           Summary: Rethink the JITOperations calling convention
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

Currently we do strange things around JITOperations calls:

- We always check exception even if we don't have to.

- Baseline JIT updates the top callframe on the JIT side, which is sort of good because it readily has the VM pointer.  But then most of the JITOperations also update the top callframe anyway.

- JITOperations don't have ready access to the JSGlobalObject* or the VM&.  When they get the JSGlobalObject*, they often do it incorrectly.  This is also tracked separately here: https://bugs.webkit.org/show_bug.cgi?id=154874

It seems that:

JITOperations should be passed the JSGlobalObject* in addition to the callframe.  The baseline JIT should never update top callframe on the JIT side - it's a waste of instructions.  JITOperations should get the VM& from the JSGlobalObject*.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160320/b250edbe/attachment-0001.html>