[Webkit-unassigned] [Bug 155686] New: ShadowChicken should integrate with DFG's existing debug data about inlined tail calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155686

            Bug ID: 155686
           Summary: ShadowChicken should integrate with DFG's existing
                    debug data about inlined tail calls
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

Currently ShadowChicken will give you confusing information when there was inlining.  That's easy to fix.  ShadowChicken doesn't need to log anything about tail calls.  We can just use the DFG's existing InlineCallFrame meta-data to fill in the missing frames.

To do this well, we need to refactor StackVisitor.  There shouldn't be a thing called StackVisitor.  There should be a functor on CallFrame, and a full-fledged object like AbstractFrame.  AbstractFrame contains all of the data about a logical stack frame, i.e. either an inline frame or machine frame.  Then, ShadowChicken::Frame can just be replaced with AbstractFrame, and the CallFrame iteration functor would use it, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160319/46b2324d/attachment.html>