[Webkit-unassigned] [Bug 155682] New: initialization loop in CARingBuffer::allocate not working because it's not iterating using a reference

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 19 08:50:16 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155682

            Bug ID: 155682
           Summary: initialization loop in CARingBuffer::allocate not
                    working because it's not iterating using a reference
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Macintosh
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Platform
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tobias.netzel at gmail.com

Created attachment 274516
  --> https://bugs.webkit.org/attachment.cgi?id=274516&action=review
patch to make the loop iterate using a reference

GCC (yes, I'm compiling for OS X but using GCC 5.3) correctly indicated that "variable 'timeBounds' set but not used".
Adding the missing reference to the type fixes the warning; the attached patch shows where.
Someone should pick this up and create a commit ready patch as I myself don't have the possibility to test on current OS X versions.

Maybe clang people should also be informed that their compiler doesn't warn this issue - or does clang automatically use a reference?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160319/0fbe70cb/attachment.html>


More information about the webkit-unassigned mailing list