[Webkit-unassigned] [Bug 155532] Provide NSSpellChecker spellChecking methods with the current insertion point

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 17 10:50:23 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155532

--- Comment #13 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #12)
> (In reply to comment #10)
> > That being said, I do not have a great understanding of any architectural
> > decisions guiding these WebCore classes. So if you think it's a
> > better/cleaner architecture here to stick to the offset, then I would be
> > happy to do that. Do you think that's better even if I add some additional
> > parameters in the future?
> 
> This is really a layering question.
> 
> Before this change, these functions were an abstract interface to spell
> checking that was independent of the DOM. After the change, they are hooks
> for spell checking that are not independent of the DOM.
> 
> I don’t have a strong feeling about which design is better, but I don’t like
> place we have landed with the division of responsibilities where extracting
> the text to spell check is a job for the caller, but interpreting the
> selection position is a job for the spell checking functions. I’d prefer
> that the work of extracting the text to spell check and the other contextual
> information needed to correctly check from the DOM was either done entirely
> by the caller or entirely by the spell checking functions.
> 
> This is not an urgent issue but nice to resolve in the longer term. We can
> talk in person about this at some point.

Sounds good! I'm happy to get this in a better place. Thanks for your input!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160317/cde4d6f0/attachment.html>


More information about the webkit-unassigned mailing list