[Webkit-unassigned] [Bug 153864] Invoking super()/super inside of the eval should not lead to SyntaxError

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153864

--- Comment #11 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 274093
  --> https://bugs.webkit.org/attachment.cgi?id=274093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274093&action=review

>>>> Source/JavaScriptCore/ChangeLog:3
>>>> +        Invoking super()/super inside of the eval should not lead to SyntaxError
>>> 
>>> Do we have a bug open for new.target inside eval?
>> 
>> Yes, I did this recently
>>  https://bugs.webkit.org/show_bug.cgi?id=155545
> 
> What I mean is shouldn't it be sufficient to just check m_codeBlock->usesEval()?
> It should never be the case that m_scopeNode->innerArrowEval() is true but m_codeBlock->usesEval() is false.
> Therefore, m_codeBlock->usesEval() should cover everything.

Hmm, before it was not, innerArrow... is set only for arrow functions and usesEval only if in current function/block we are using eval. So as for now:
  m_codeBlock->usesEval() is true but m_scopeNode-innerArrowEval() is false for this case -> var f = function () { eval('debug("hello world")'); }; f();
  m_codeBlock->usesEval() is false but m_scopeNode->innerArrowEval() true for case -> var f = function () { var arr = () => () =>  eval('debug("hello world")'); }; f();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160316/248c35f1/attachment.html>