[Webkit-unassigned] [Bug 155535] WebRTC: Update RTCIceCandidate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155535

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274185|review?                     |review+
              Flags|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 274185
  --> https://bugs.webkit.org/attachment.cgi?id=274185
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274185&action=review

> Source/WebCore/ChangeLog:9
> +        In short: The "candidate" init dictionary member is required. At least one of dictionary

Nit: At least one of *the* ...

> Source/WebCore/Modules/mediastream/RTCIceCandidate.cpp:61
> +        if (!intConversionOk || result > 65535) {

Nit: you can use USHRT_MAX here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160316/1b7e3b6b/attachment.html>