[Webkit-unassigned] [Bug 155524] Add Automation.evaluateJavaScriptFunction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155524

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 274158
  --> https://bugs.webkit.org/attachment.cgi?id=274158
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=274158&action=review

> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:43
> +static JSObjectRef toJSArray(JSContextRef context, const Vector<T>& data, JSValueRef (*converter)(JSContextRef, const T&), JSValueRef* exception = 0)

Only nit I have is this 0 could be nullptr.

> Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:48
> +        return JSObjectMakeArray(context, 0, 0, exception);

Second 0 here could be nullptr.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160316/bd44d49f/attachment.html>