[Webkit-unassigned] [Bug 153864] Invoking super()/super inside of the eval should not lead to SyntaxError

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153864

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274093|review?                     |review+
              Flags|                            |

--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 274093
  --> https://bugs.webkit.org/attachment.cgi?id=274093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274093&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Invoking super()/super inside of the eval should not lead to SyntaxError

Do we have a bug open for new.target inside eval?

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:643
>> +    if (needsToUpdateArrowFunctionContext() && !codeBlock->isArrowFunctionContext() && !isDerivedConstructorContext()) {
> 
> Why the "!isDerivedConstructorContext()" check?

Ah, I guess it's that way so we don't recreate a scope. I think I understand.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160316/ca137705/attachment.html>