[Webkit-unassigned] [Bug 155469] AX: Expose aria-current status to children

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155469

--- Comment #6 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 274039
  --> https://bugs.webkit.org/attachment.cgi?id=274039
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274039&action=review

>>>> Source/WebCore/accessibility/AccessibilityObject.cpp:1881
>>>> +    // If empty or missing, we should walk the parent chain to find the current status.
>>> 
>>> should we do this for every object, or should VoiceOver be responsible for checking the parent chain for the presence of aria-current?
>>> i feel like the later might be more performant and more accurate.
>> 
>> I did have the same concern when implementing this. I'll try the VO approach too, but even in that case, we still need to check every object, right?
> 
> true but VO only has to do it when it needs to output the info. Does webkit end up calling this method for every object when its retrieved? or does it also only return this info when explicitly asked.
> 
> I feel its also slightly more accurate to only expose this on the actual element that does expose it.

Webkit is calling this method for every object, but only expose the attribute when result is not false. I think I should change that part to make it work for VO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160315/43372ef5/attachment.html>