[Webkit-unassigned] [Bug 155395] [iOS]=?UTF-8?Q?=20WKPreviewAction=20conforms=20to=20NSCopying=20but=20doesn=E2=80=99t=20override=20=2DcopyWithZone?=:

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155395

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274024|review?                     |review+
              Flags|                            |

--- Comment #9 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 274024
  --> https://bugs.webkit.org/attachment.cgi?id=274024
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=274024&action=review

You should remove the explicit conformance to NSCopying of WKPreviewAction since UIPreviewAction already conforms to it.

> Source/WebKit2/UIProcess/API/Cocoa/WKPreviewActionItem.mm:45
> +    WKPreviewAction *action = [super copyWithZone:zone];
> +    action->_identifier = self.identifier;
> +    return action;

Since WKPreviewAction is immutable, this can be implemented as:

    return [self retain];

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160314/0317b651/attachment.html>