[Webkit-unassigned] [Bug 155445] check-webkit-style: should warn when blank line appears between #include "config.h" and #include "ThisFileName.h"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 11:43:01 PDT 2016


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
            Summary|check-webkit-style: warn    |check-webkit-style: should
                   |when blank lines appear     |warn when blank line
                   |between #include "config.h" |appears between #include
                   |and #include                |"config.h" and #include
                   |"ThisFileName.h"            |"ThisFileName.h"

--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Strangely, this only appears to fail in RefLogger.cpp:

Steps to reproduce:
1. git checkout bb9b34395effabdaeec2b92e42cee9df70aad271^
2. ./Tools/Scripts/check-webkit-style ./Tools/TestWebKitAPI/Tests/WTF/RefLogger.cpp

Expected results:
ERROR: Tools/TestWebKitAPI/Tests/WTF/RefLogger.cpp:28:  You should not add a blank line before implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 1 files

Actual results:
Total errors found: 0 in 1 files

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160314/8816f0a4/attachment.html>

More information about the webkit-unassigned mailing list