[Webkit-unassigned] [Bug 155445] check-webkit-style: warn when blank lines appear between #include "config.h" and #include "ThisFileName.h"

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 14 10:56:58 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=155445

--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
For funsies, I wrote a command-line to find all the "violators" in Source:

$ find Source -type f -exec perl -e 'use File::Basename; undef $/; my $file = $ARGV[0]; my $base = basename($file); $base =~ s/\.[a-z]+$//; my $content = <>; print "$file\n" if ($content =~ m/#include "config.h"\n\n#include "${base}.h"/mg);' {} \;
Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp
Source/JavaScriptCore/runtime/CodeCache.cpp
Source/JavaScriptCore/runtime/PropertyDescriptor.cpp
Source/WTF/wtf/dtoa/bignum.cc
Source/WTF/wtf/dtoa/diy-fp.cc
Source/WTF/wtf/dtoa/fast-dtoa.cc
Source/WebCore/bindings/js/JSWorkerGlobalScopeBase.cpp
Source/WebCore/css/CSSBasicShapes.cpp
Source/WebCore/css/CSSGroupingRule.cpp
Source/WebCore/css/WebKitCSSRegionRule.cpp
Source/WebCore/dom/ChildListMutationScope.cpp
Source/WebCore/dom/MutationObserver.cpp
Source/WebCore/dom/MutationObserverInterestGroup.cpp
Source/WebCore/dom/MutationObserverRegistration.cpp
Source/WebCore/fileapi/BlobURL.cpp
Source/WebCore/fileapi/FileReader.cpp
Source/WebCore/fileapi/FileReaderLoader.cpp
Source/WebCore/fileapi/FileReaderSync.cpp
Source/WebCore/html/TimeRanges.cpp
Source/WebCore/html/canvas/CanvasContextAttributes.cpp
Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
Source/WebCore/platform/CrossThreadCopier.cpp
Source/WebCore/platform/FileStream.cpp
Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
Source/WebCore/platform/graphics/GraphicsLayer.cpp
Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Source/WebCore/platform/graphics/ca/LayerFlushScheduler.cpp
Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp
Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp
Source/WebCore/platform/graphics/gpu/TilingData.cpp
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp
Source/WebCore/platform/graphics/win/MediaPlayerPrivateTaskTimer.cpp
Source/WebCore/platform/network/BlobResourceHandle.cpp
Source/WebCore/platform/network/FormData.cpp
Source/WebCore/platform/win/StructuredExceptionHandlerSuppressor.cpp
Source/WebCore/rendering/FilterEffectRenderer.cpp
Source/WebCore/rendering/RenderLayerBacking.cpp
Source/WebCore/rendering/RenderLayerCompositor.cpp
Source/WebCore/rendering/RenderMarquee.cpp
Source/WebCore/rendering/RenderRuby.cpp
Source/WebCore/rendering/RenderRubyBase.cpp
Source/WebCore/rendering/RenderRubyRun.cpp
Source/WebCore/rendering/RenderRubyText.cpp
Source/WebCore/rendering/style/BasicShapes.cpp
Source/WebCore/svg/SVGZoomEvent.cpp
Source/WebCore/workers/DedicatedWorkerThread.cpp
Source/WebCore/workers/Worker.cpp
Source/WebCore/workers/WorkerScriptLoader.cpp
Source/WebCore/workers/WorkerThread.cpp
Source/WebKit2/NetworkProcess/NetworkLoad.cpp
Source/WebKit2/Shared/WebPopupItem.cpp

And in Tools:

$ find Tools -type f -exec perl -e 'use File::Basename; undef $/; my $file = $ARGV[0]; my $base = basename($file); $base =~ s/\.[a-z]+$//; my $content = <>; print "$file\n" if ($content =~ m/#include "config.h"\n\n#include "${base}.h"/mg);' {} \;
Tools/TestWebKitAPI/PlatformUtilities.cpp
Tools/TestWebKitAPI/Tests/WTF/RefLogger.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160314/06f08b80/attachment.html>


More information about the webkit-unassigned mailing list