[Webkit-unassigned] [Bug 155431] Leak: Accelerated ImageBufferCairo doesn't destroy the used textures

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155431

--- Comment #3 from Miguel Gomez <magomez at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 273958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273958&action=review
> 
> > Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:88
> > +    if (!m_texture)
> > +        return;
> 
> I assume m_texture has to be present for m_compositorTexture to be created,
> but it would be better not to count on that, and just either delete
> m_texture or m_compositorTexture if they are non-null.

Yes, using an accelerated path m_texture must exist and m_compositorTexture may or may not. I'll simplify it.

> > Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:90
> > +    GLContext::sharingContext()->makeContextCurrent();
> 
> This destructor should store the previous context and restore it when done,
> as we usually do.

Ok.

> At some point, we should also use a separate offscreen context for the
> accelerated canvas, and not the sharing context.

Agree.

> > Source/WebCore/platform/graphics/cairo/ImageBufferDataCairo.h:58
> > +    ~ImageBufferData();
> 
> This should be virtual.

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160314/e5f7b98d/attachment.html>