[Webkit-unassigned] [Bug 153176] [CMake][GTK][OSX] ThreadIdentifierData::initialize assertion fails because there are two copies of WTF in process (one as part of webkit2, one as part of jsc)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=153176

--- Comment #14 from Philip Chimento <philip.chimento at gmail.com> ---
Created attachment 273923
  --> https://bugs.webkit.org/attachment.cgi?id=273923&action=review
Doesn't fix the problem

I've been trying to correct this, but have been trying various combinations of PUBLIC, PRIVATE, and INTERFACE all weekend (and waiting most times for WebCore to rebuild, as cmake doesn't seem to be able to determine that all I've changed is the linking libraries). Attached is a work-in-progress patch (not formatted for committing) of what I have now, which doesn't fix the crash.

I think the problem is that I don't understand how the various convenience libraries should be linked together. From the other comments here, it seems it should be something like this:

WTF -> convenience library, linked into JavaScriptCore
    -> symbols used from JavaScriptCore, WebCore, and WebKit2

JavaScriptCore -> public, uses and exports WTF symbols

WebCore -> convenience library, linked into WebKit2
        -> uses WTF and JavaScriptCore symbols
        -> symbols used from WebKit2

WebKit2 -> public, uses WTF, JavaScriptCore, WebCore symbols

I _think_ that's what I've implemented in the patch, but I still end up with JavaScriptCore and WebKit2 each containing their own copy of WTF.

Advice would be appreciated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160314/11f9a207/attachment.html>