[Webkit-unassigned] [Bug 155390] New: eventMayStartDrag() does not check for shiftKey or isOverLink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155390

            Bug ID: 155390
           Summary: eventMayStartDrag() does not check for shiftKey or
                    isOverLink
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Event Handling
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tonikitoo at webkit.org

This is a follow up of Darin's comment in https://bugs.webkit.org/show_bug.cgi?id=155314#c9.

Basically in bug 155314, in order to make shift+click not trigger drag-n-drop when extending an existing selection, we changed the way m_mouseDownMayStartDrag is set on EventHandler::handleMousePressEvent, as shown below:

-    m_mouseDownMayStartDrag = singleClick;
+    m_mouseDownMayStartDrag = singleClick && (!event.event().shiftKey() || event.isOverLink());

Although makes a desired change in WebKit's editing behavior (as per [1] and [2]), it makes this setter code get out of sync with eventMayStartDrag.

Bug is about investigating the implications, and sync both pieces up again.

[1] https://bugs.webkit.org/show_bug.cgi?id=155314#c4
[2] https://bugs.webkit.org/show_bug.cgi?id=155314#c8

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160312/5a0cc067/attachment.html>