[Webkit-unassigned] [Bug 155255] MemoryPressureHandler doesn't work if cgroups aren't present in Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155255

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273748|commit-queue?               |commit-queue-
              Flags|                            |

--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 273748
  --> https://bugs.webkit.org/attachment.cgi?id=273748
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273748&action=review

cq- for now while we discuss whether it's worth it supporting this or not.

> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:143
> +            if (ReliefLogger::loggingEnabled())
> +                LOG(MemoryPressure, "Polled memory pressure (%s)", isUnderMemoryPressure ? "critical" : "non-critical");
> +
> +            MemoryPressureHandler::singleton().setUnderMemoryPressure(isUnderMemoryPressure);
> +            callOnMainThread([isUnderMemoryPressure] {
> +                MemoryPressureHandler::singleton().respondToMemoryPressure(isUnderMemoryPressure ? Critical::Yes : Critical::No);
> +            });

This is mostly duplicated code, we could probably move it to a function that receives the isUnderMemoryPressure value.

> Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp:149
> +        sleep(s_pollingIntervalInSeconds);
> +    } while (true);

I'm not happy with this either, but I have no idea how to do this if meminfo is not pollable. Note that there's one memory pressure handler per process . . .

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160312/e1534b54/attachment-0001.html>