[Webkit-unassigned] [Bug 155389] New: When generating Objective-C protocol types, getters for objects need to synthesize a new object instance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 11 23:32:02 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=155389

            Bug ID: 155389
           Summary: When generating Objective-C protocol types, getters
                    for objects need to synthesize a new object instance
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: bburg at apple.com
                CC: bburg at apple.com, graouts at webkit.org,
                    joepeck at webkit.org, mattbaker at apple.com,
                    nvasilyev at apple.com, timothy at apple.com,
                    webkit-bug-importer at group.apple.com

The current code does this (for example):

- (AutomationPoint *)origin
{
    return (AutomationPoint *)[super objectForKey:@"origin"];
}

However, at runtime the class of self is going to be RWIProtocolJSONObject *, not AutomationPoint *, so any subsequent calls to AutomationPoint properties on the return value will fail as the selectors will not be recognized.

Instead of doing a C-style pointer cast, we need to create a new AutomationPoint object that's backed by the InspectorObject retrieved from the parent object by key. This requires a new initWithXXX initializer for each object protocol type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160312/bbb4b872/attachment.html>


More information about the webkit-unassigned mailing list