[Webkit-unassigned] [Bug 155343] [iOS] Allow clients to specify text suggestions to be used for a form input session

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155343

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273685|review?                     |review-
              Flags|                            |

--- Comment #2 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 273685
  --> https://bugs.webkit.org/attachment.cgi?id=273685
Patch to resolve [iOS] Allow clients to specify text suggestions to be used for a form input session

View in context: https://bugs.webkit.org/attachment.cgi?id=273685&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:313
> +    id <UITextInputSuggestionDelegate> suggestionDelegate = (id <UITextInputSuggestionDelegate>)_contentView.inputDelegate;

Should we assert that this was a valid cast?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:314
> +    _suggestions = suggestions;

You should adhere to the API contract and copy the array here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160311/f8102a65/attachment.html>