[Webkit-unassigned] [Bug 155056] AX: Force allow user zoom

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 12:35:51 PST 2016


https://bugs.webkit.org/show_bug.cgi?id=155056

--- Comment #32 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 273273
  --> https://bugs.webkit.org/attachment.cgi?id=273273
Support the Internals setting on Mac

View in context: https://bugs.webkit.org/attachment.cgi?id=273273&action=review

> Source/WebCore/testing/Internals.h:481
> +    void setViewportForceAlwaysUserScalable(bool);
> +    double viewportConfigurationMaximumScale();

I don't think you need this stuff here if you use UIScriptController tests.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:220
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> +#include <WebCore/SoftLinking.h>
> +SOFT_LINK_LIBRARY(libAccessibility)
> +SOFT_LINK(libAccessibility, _AXSForceAllowWebScaling, Boolean, (), ())
> +SOFT_LINK_CONSTANT(libAccessibility, kAXSAllowForceWebScalingEnabledNotification, CFStringRef)
> +#define kAXSAllowForceWebScalingEnabledNotification getkAXSAllowForceWebScalingEnabledNotification()
> +#endif

This is not a platform-specific file, and should not have this here.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:279
> +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> +static void forceAlwaysUserScalableChangedCallback(CFNotificationCenterRef, void* observer, CFStringRef, const void*, CFDictionaryRef)
> +{
> +    ASSERT(observer);
> +    static_cast<WebPage*>(observer)->updateForceAlwaysUserScalable();
> +}
> +#endif

Ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:569
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> +    CFNotificationCenterAddObserver(CFNotificationCenterGetLocalCenter(), this, forceAlwaysUserScalableChangedCallback, kAXSAllowForceWebScalingEnabledNotification, 0, CFNotificationSuspensionBehaviorDeliverImmediately);
> +#endif

Ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:604
> +#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> +    CFNotificationCenterRemoveObserver(CFNotificationCenterGetLocalCenter(), this, nullptr, nullptr);
> +#endif

Ditto.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2835
> +#if PLATFORM(IOS)
> +void WebPage::updateForceAlwaysUserScalable()
> +{
> +    bool forceAlwaysUserScalableEnabled = m_forceAlwaysUserScalable;
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000
> +    forceAlwaysUserScalableEnabled |= _AXSForceAllowWebScaling();
> +#endif
> +    m_viewportConfiguration.setForceAlwaysUserScalable(forceAlwaysUserScalableEnabled);
> +}
> +#endif

Move to WebPageIOS.mm

> LayoutTests/ChangeLog:9
> +        * accessibility/ios-simulator/force-user-scalable-expected.txt: Added.
> +        * accessibility/ios-simulator/force-user-scalable.html: Added.

I would prefer that these tests use UIScriptController to test that the view is actually zoomable. See tests under LayoutTests/fast/viewport/ios/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160308/6387311a/attachment.html>


More information about the webkit-unassigned mailing list