[Webkit-unassigned] [Bug 154976] AX: Implement bounds/position and index related text marker functions using TextIterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154976

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 272834
  --> https://bugs.webkit.org/attachment.cgi?id=272834
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272834&action=review

> Source/WebCore/ChangeLog:9
> +        VoiceOver navigation issue.

issues.

what are those issues?

> Source/WebCore/accessibility/AXObjectCache.cpp:2329
> +    InlineBox* inlineBox;

initialize to nullptr just in case the getInlineBox doesn't do it

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1967
> +    LayoutRect ourrect = rect1;

ourRect

> LayoutTests/ChangeLog:8
> +        * accessibility/mac/text-marker-for-index-expected.txt: Added.

do you have test for textMarkerForPosition, line navigation and text marker bounds?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160308/dfccaf46/attachment.html>