[Webkit-unassigned] [Bug 155130] New: Fix lifetime issues regarding WebVideoFullscreenInterfaceMac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155130

            Bug ID: 155130
           Summary: Fix lifetime issues regarding
                    WebVideoFullscreenInterfaceMac
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: adachan at apple.com

When WebVideoFullscreenManager::setUpVideoControlsManager() is called, we always clean up the old WebVideoFullscreenInterfaceContext associated with the context id associated with the current video controls manager and make a new one.  This is an issue if we are in the middle of handling fullscreen and it's still using that WebVideoFullscreenInterfaceContext, since a lot of fullscreen state is kept with that particular context.

Before the introduction of video controls manager, we only use WebVideoFullscreenInterfaceContext for full screen, so it's ok to invalidate the interface right after we exit the fullscreen mode. But now we need to do more bookkeeping since video controls manager also depends on WebVideoFullscreenInterfaceContext. We should keep track of a "client count" for each context ID so we'll only remove it from the context map when there are all clients are done with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160307/f74d62a6/attachment-0001.html>