[Webkit-unassigned] [Bug 155047] [CMake] Build with Werror in DEVELOPER_MODE (except on the bots)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 5 17:00:02 PST 2016


--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #5)
> Another source of warnings is unused arguments in case function contains #if
> guards. Silencing that would require addition of lots of source lines

You shouldn't see any of these, that's what the UNUSED_PARAM macro is for! Yes, it is often annoying to silence these, but we made a project decision not to disable the warning, though there's a good argument to be made for disabling that warning. (I'm currently planning to do so for DerivedSources only, as that's currently the only place we see any of these, at least on the GTK port.)

But it's irrelevant to whether we should turn warnings into errors, as we don't want preexisting warnings preventing developers from detecting new warnings. Enforcing -Werror in development builds is the best way to ensure the build stays clean and shiny. If you don't want to fix them, you can just use -DENABLE_WERROR=OFF.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160306/0c735902/attachment.html>

More information about the webkit-unassigned mailing list