[Webkit-unassigned] [Bug 155021] Added missing override specifiers under Source/WebCore.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155021

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #272981|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 272981
  --> https://bugs.webkit.org/attachment.cgi?id=272981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272981&action=review

Neat!

> Source/WebCore/page/DebugPageOverlays.cpp:62
> +    void pageOverlayDestroyed(PageOverlay&) final;
> +    void willMoveToPage(PageOverlay&, Page*) final;
> +    void didMoveToPage(PageOverlay&, Page*) final;
> +    void drawRect(PageOverlay&, GraphicsContext&, const IntRect& dirtyRect) final;
> +    bool mouseEvent(PageOverlay&, const PlatformMouseEvent&) final;
> +    void didScrollFrame(PageOverlay&, Frame&) final;

Looks wrong. We removed virtual here but did not add override. Maybe a bug in the tool.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160304/f6ddac49/attachment.html>