[Webkit-unassigned] [Bug 154628] Use IndentTextOrNot instead of passing isFirstLine/shouldIndentText as bool.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154628

--- Comment #6 from zalan <zalan at apple.com> ---
(In reply to comment #4)
> Comment on attachment 272083 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=272083&action=review
> 
> > Source/WebCore/rendering/RenderBlock.h:125
> > +    LayoutUnit availableLogicalWidthForLineInRegion(LayoutUnit position, IndentTextOrNot shouldIndentText, RenderRegion* region, LayoutUnit logicalHeight = 0) const
> 
> I dislike names with "OrNot." How about ShouldIndentText? ShouldIndent?
> IndentionRequired?

I dislike it very much too, but i'd rather have it in a follow-up patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160302/e950e3e2/attachment.html>